Remove KHR_texture_transform distinction in UCesiumFeaturesMetadataComponent
#1765
+113
−163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Member
|
@j9liu I tried this test:
This makes the model turn grey: I can't see any errors or warnings or anything relevant in the log. That's unexpected, right? |
Member
|
I guess the problem is that everything has been disconnected: I thought user connections were supposed to be preserved when regenerating the material, but maybe I'm misremembering. |
Contributor
Author
They're supposed to, but for some reason the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #1757, so merge that first.
This change removes the non-meaningful
bHasKhrTextureTransformproperties fromFCesiumFeatureIdSetDescriptionandFCesiumPropertyTexturePropertyDescription. Now, it will always generate nodes to intercept any scale / offset / rotation parsed fromKHR_texture_transform.This simplifies some of the implementation in #1762, so IMO it is a worthwhile and easy change. It also won't break any existing materials because there are already correct default values when sampling feature ID textures anyway.
Issue number or link
Closes #1760.
Author checklist
CHANGES.mdwith a short summary of my change (for user-facing changes).[ ] I have added or updated unit tests to ensure consistent code coverage as necessary.Testing plan
Although #1764 exists, it's still possible to test the actual generation of nodes in the material. Also open
06_CesiumMetadatato check that it still works, since it uses feature ID textures without theKHR_texture_transformextension.